Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: change _rangeEnd to today #13

Merged

Conversation

hackolein
Copy link
Contributor

Change the _rangeEnd Date to today, because it can not be empty. It's the fallback, if there is no rangeEnd is given.

Change the _rangeEnd Date to today, because it can not be empty. It's the fallback, if there is no rangeEnd is given.
@thelfensdrfer
Copy link
Member

This confirms better with the documentation of the paremter Leave this parameter empty to request all data from $rangeStart until now, but $this->_date = $rangeStart; was valid too. It only set the range to one day, the start day.

@thelfensdrfer thelfensdrfer merged commit f927bdd into VisualAppeal:master Feb 13, 2015
@hackolein
Copy link
Contributor Author

Ok, but when I left the parameter blank, then I get the following error message back:
{
"result": "error",
"message": "Das Datum '2014-12-10,' ist keine korrekte Zeitspanne. Es sollte das folgende Format haben: 'lastN', 'previousN', 'YYYY-MM-DD,YYYY-MM-DD'"
}

With the API call: "... period=range&format=json&language=de& ... &date=2014-12-10,"

But, now it works 👍

@thelfensdrfer
Copy link
Member

Ok this is strange, the start range should be copied to the end range...but great that it works now!

@hackolein hackolein deleted the feature/FixDefaultEndRange branch April 13, 2015 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants