Updated documentation for idleTimeoutMillis #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you very much. We're facing a similar issue; interestingly enough, it happens only when SELECT'ed rows are bin data. |
|
Thanks, this is good addition 👍 |
|
added also feature idea to allow keeping idle resources in the pool fresh #75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a long time to figure out why
idleTimeoutMilliswasn't applying to all my connections. Some of them were kept open for hours, became stale and caused all sorts of trouble.After lots of debugging, I realised that the
minoption was the culprit, defaulting to 2 in Knex.The idle timeout is only applied if there are more connections than the minimum.
It seems like a good idea to document this behavior so others could figure it out more easily 🙂