[pull] master from segmentio:master #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
The `Dialog` component wraps the `children` with two `Pane`'s -- one that you can supply custom props to, and another that you cannot. Because of that second pane, you can't supply a custom header and footer via the body and still have those header/footer stick to the top/bottom of the Dialog (CMIIW!). We can't just remove that `Pane`, since it would break the rendering behavior of children in a `Dialog`. As a compromise, this PR introduces a `header` and `footer` component that can be used to override the default header and footer. | Before | After | | --- | --- | | Scrolling doesn't work:  | Scrolling works:  |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )