python 3.5 compatibility #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Behavior in 2.7 is unchanged. 3.5 mimics 2.7 in full with the exception of defaulting to unicode instead of ascii. an ascii flag/modifier was added to mimic old behavior.
fixed for 3.5
| @@ -136,5 +137,6 @@ def test_should_match_email_address(self): | |||
| self.assertRegexpMatches('[email protected]', self.exp, 'Not a valid email') | |||
|
|
|||
| def test_should_match_url(self): | |||
| self.exp = self.v.start_of_line().then('http').maybe('s').then(':https://').maybe('www.').word().then('.').word().maybe('/').end_of_line().regex() | |||
| self.exp = self.v.start_of_line().then('http').maybe('s').then(':https://').maybe('www.').word().then('.').word()\ | |||
There was a problem hiding this comment.
is the backslash at the end necessary ?
|
I will close and reopen to trigger the travis build. |
|
@Kristinita can we make the travis build to pass ? |
vtitor
added a commit
that referenced
this pull request
Jan 4, 2018
vtitor
added a commit
that referenced
this pull request
Jan 4, 2018
|
@Kharms Thanks for this, I have applied part of your changes. |
|
@Kristinita I guess, now you can find the necessary stuff at the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavior in 2.7 is unchanged. 3.5 mimics 2.7 in full with the exception
of defaulting to unicode instead of ascii. an ascii flag/modifier was
added to mimic old behavior.