-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error running basin_stats with a data_id not in catalog metadata #148
Comments
Should be easy enough to implement. For this particular case (and maybe others like it), I think the solution would be to put deprecated assets in rabpro's user_added_catalog. This would avoid errors but this is probably a case where you want it to fail (if you weren't aware of the new version) so maybe that's a bad idea. |
Should we enable users to override any checks against the catalog and just run the query? For reasons that are unclear to me, DAYMET does not appear in the scraped json but is clearly available in the GEE catalog. |
Yes, I think so. I was struggling with this for VotE forcings/characteristics fetching as well. |
The two dataset attributes that you get "for free" if your entry is in the catalog is |
Consider this scenario:
This is because the call to
Dataset
emits a warning (not an error) and passes on an empty output tobasin_stats.compute
because the id is not in the catalog (I think this is fine).compute
attempts to proceed as normal with the "empty" request (I think this is not fine). We should probably catch these incompute
and throw an error.The text was updated successfully, but these errors were encountered: