-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BinaryVDF.test_loads_utf16 not passed #33
Comments
That could only happen at https://github.com/ValvePython/vdf/blob/master/vdf/__init__.py#L361 Which means that I'd say this is a bug and I suppose the temporary fix is set the decode to |
@tim77, if you're reporting a build/test failure on an unusual CPU architecture, please say so up-front? Otherwise maintainers will tend to assume that you were building on x86. Debian s390x (which is big-endian) is exhibiting the same build failure (after I fixed a packaging bug that meant we weren't actually running the tests as we intended to). I'll send a merge request shortly. |
Integers in binary VDF are already treated as little-endian (least significant byte first) regardless of CPU architecture, but the 16-bit units in UTF-16 didn't get the same treatment. This led to a test failure on big-endian machines. Resolves: ValvePython#33 Signed-off-by: Simon McVittie <[email protected]>
Some tests not passed in Fedora 32:
But tests passed in Fedora 33 and no such issue. Full F32 build log.
Additional information:
Fedora 32
3.8.7
The text was updated successfully, but these errors were encountered: