Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to NaN checking #35

Open
ahojukka5 opened this issue Nov 24, 2023 · 0 comments
Open

Improvements to NaN checking #35

ahojukka5 opened this issue Nov 24, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@ahojukka5
Copy link
Collaborator

  1. Let's enable NaN checking somewhere in an automatic way if DCMAKE_BUILD_TYPE=Debug. It's well justified as in debug mode all optimizations are anyway disabled and performance doesn't matter.
  2. Let's add option to enable NaN checking also in production code using json input file. Some kind of "enable_nan_check": true.
  3. In documentation, create "debugging" page or section, describing some strategies how to debug a nonworking model. At least describe the use of abortIfNaNs. Mention also that issue Validate json file when loading configuration #31 might be a good source of NaNs if input data is missing.
@ahojukka5 ahojukka5 added the enhancement New feature or request label Nov 24, 2023
@ahojukka5 ahojukka5 added this to the 0.1.2 milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant