Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate json file when loading configuration #31

Open
ahojukka5 opened this issue Nov 18, 2023 · 1 comment
Open

Validate json file when loading configuration #31

ahojukka5 opened this issue Nov 18, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ahojukka5
Copy link
Collaborator

It's nice to have NaN checks:

NaNs detected on process 1 at /home/juajukka/dev/openpfc/apps/tungsten.cpp:165. Aborting MPI application.

However, it would be much nicer to validate json inputs so that all necessary things are certainly defined.

  1. If something non-critical is missing, give warning and use some meaninful default
  2. If something critical is missing, stop the program and describe what needs to be added

https://github.com/pboettch/json-schema-validator

@ahojukka5 ahojukka5 added the enhancement New feature or request label Nov 18, 2023
@ahojukka5 ahojukka5 added this to the 0.2 milestone Nov 18, 2023
@ahojukka5 ahojukka5 self-assigned this Nov 18, 2023
@ahojukka5
Copy link
Collaborator Author

Actually there is some poor man's validation in (https://github.com/VTT-ProperTune/OpenPFC/blob/master/apps/aluminumNew/Aluminum.hpp#L308), but maybe better to implement it in a proper way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant