fix(Popover): fix hover behavior conflicts #7170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 022f180 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7170 +/- ##
==========================================
- Coverage 84.07% 84.07% -0.01%
==========================================
Files 359 359
Lines 10909 10908 -1
Branches 3591 3590 -1
==========================================
- Hits 9172 9171 -1
Misses 1737 1737
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SevereCloud
approved these changes
Jul 11, 2024
vkcom-publisher
pushed a commit
that referenced
this pull request
Jul 16, 2024
h2. Описание
Если мы задавали `trigger={['focus', 'click', 'hover']}`, то событие `mouseLeave` игнорировалось в случае, если триггером выступал `focus` или `click`, это приводило к путающему поведению:
| Было | Стало |
| ------------- | ------------- |
| <video src="https://github.com/VKCOM/VKUI/assets/7431217/1b35c96e-939a-49df-8bd9-150b51ee1413"> | <video src="https://github.com/VKCOM/VKUI/assets/7431217/51d86a43-e3e3-4a02-8860-8d793aec2107">|
h2. Изменения
Убираем игнор `focus`/`click` событий, изменяем тесты на проверку взаимозаменяющего поведения
| ✅ v6.2.2 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Если мы задавали
trigger={['focus', 'click', 'hover']}, то событиеmouseLeaveигнорировалось в случае, если триггером выступалfocusилиclick, это приводило к путающему поведению:2024-07-10.22.51.13.mov
2024-07-10.22.53.08.mov
Изменения
Убираем игнор
focus/clickсобытий, изменяем тесты на проверку взаимозаменяющего поведения