Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Login Bug #950

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Fix Login Bug #950

merged 1 commit into from
Feb 10, 2023

Conversation

jumaallan
Copy link
Member

@jumaallan jumaallan commented Feb 10, 2023

I wasn't so sure why this was happening, so I tried to check a few things:

  • changed StaxUserUseCase from a factory to a singleton
  • removed the redundant user check since we use OnConflictStrategy.REPLACE in BaseDao

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests are added/updated (if necessary)
  • Ensure the linter passes (./codeAnalysis to automatically apply formatting/linting)
  • Appropriate docs were updated (if necessary)

Fixes #950 🦕

@jumaallan jumaallan self-assigned this Feb 10, 2023
@jumaallan jumaallan added this pull request to the merge queue Feb 10, 2023
Merged via the queue into development with commit d61b236 Feb 10, 2023
@jumaallan jumaallan deleted the bug/fix-login branch February 10, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants