Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Correct handling of unused 'subset' parameter in fasttext_filter (#54) #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FIX: Correct handling of unused 'subset' parameter in fasttext_filter (#54) #55

wants to merge 1 commit into from

Conversation

41ow1ives
Copy link
Collaborator

@41ow1ives 41ow1ives commented May 24, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows dataverse guidelines link:
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What does this PR do?

@41ow1ives 41ow1ives added the Bug Something isn't working label May 24, 2024
@41ow1ives 41ow1ives requested review from Kimyungi and p-idx May 24, 2024 05:21
@41ow1ives 41ow1ives self-assigned this May 24, 2024
@p-idx
Copy link
Contributor

p-idx commented Jun 27, 2024

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kimyungi Kimyungi Awaiting requested review from Kimyungi

@p-idx p-idx Awaiting requested review from p-idx

At least 1 approving review is required to merge this pull request.

Assignees

@41ow1ives 41ow1ives

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@41ow1ives @p-idx