Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - Report a valid robot state (robot_mode/safety_state/program_state) when running with mock hardware. #976

Open
firesurfer opened this issue Apr 22, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@firesurfer
Copy link
Contributor

firesurfer commented Apr 22, 2024

Feature summary

I am currently implementing a diagnostics node. (As you might have guessed from the other issues).
At the moment the GPIOController simply doesn't report anything when run with fake/mock hardware as far as I can tell.
It would be nice if it would report:

Robot Mode: Running
Safety Mode: Normal
Program State: true (running)

Related issues

#974
#973

Implementation

There are two ways to implement this:

A) The GPIOController needs access to the information if it is running with mock hardware and could adapt the status report accordingly

B) It is apparently possible to use: fake_sensor_commands in order to provide arbitrary information on state interfaces. When launched with mock hardware we could make sure that the states listed above are set to the corresponding state interfaces.

@firesurfer firesurfer added the enhancement New feature or request label Apr 22, 2024
@fmauch
Copy link
Collaborator

fmauch commented Apr 24, 2024

That sounds like a reasonable thing to do, thank you for the issue. Intuitively I would say that fake_sensor_commands should be the way to go.

For anybody who wants to implement this: We plan to separate the GPIO controller a bit in the near future, so implementing this feature in an own controller might make life easier.

@fmauch fmauch added the help wanted Extra attention is needed label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants