Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calibration file to launch arguments #1001

Merged
merged 4 commits into from
May 22, 2024

Conversation

VinDp
Copy link
Collaborator

@VinDp VinDp commented May 22, 2024

At the moment passing the robot calibration as launch argument is not possible in Humble, but only on Rolling. These changes allow that and they should also fix #918.

@VinDp VinDp requested a review from fmauch May 22, 2024 14:09
Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old kinemtatics_params = PathJoinSubstitution... statement should probably also go. Oh, and the file from ur_bringup should also be updated.

Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VinDp

@fmauch fmauch merged commit 009458a into UniversalRobots:humble May 22, 2024
6 checks passed
@VinDp VinDp deleted the calibration_launch branch May 22, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing "robot_calibration.yaml" not working via lauch-parameter "kinematics_config"
2 participants