Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Origin/morwenna/hackweek branch #731

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Origin/morwenna/hackweek branch #731

wants to merge 1 commit into from

Conversation

MorwennaG
Copy link
Collaborator

@MorwennaG MorwennaG commented Sep 15, 2022 •
edited
Loading

UX: Enter key shortcut after entering IP address is resolved by adding On Submit to IPJoiningUI and IPHostingUI.

Ticket link: https://jira.unity3d.com/browse/MTT-3784.

Issue Number(s)

MTT-3784

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@MorwennaG
MTT-3784: Enter key shortcut after entering IP address
662db01 
'UX: Enter key shortcut after entering IP address' is resolved by adding On Submit to IPJoiningUI and IPHostingUI.

Ticket link: https://jira.unity3d.com/browse/MTT-3784.
@MorwennaG MorwennaG added 2-Easy This PR is trivial and can be reviewed quickly priority:medium labels Sep 15, 2022
@MorwennaG MorwennaG self-assigned this Sep 15, 2022
@SamuelBellomo
Copy link
Contributor

Congratz on the first PR!
This should merge to develop, not main.
Also make sure to check mark the list in the description.

@MorwennaG MorwennaG changed the base branch from main to develop September 16, 2022 13:54
SamuelBellomo
SamuelBellomo reviewed Sep 23, 2022
View reviewed changes
ProjectSettings/ProjectVersion.txt
@@ -1,2 +1,2 @@
m_EditorVersion: 2021.3.2f1
m_EditorVersionWithRevision: 2021.3.2f1 (79cbdb13f624)
m_EditorVersion: 2021.3.9f1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to commit only the changes related to your PR
With this, you're bumping the editor version for everyone. With that editor bump comes Lobby updates which our code base isn't ready to accept yet (LP and Fernando are working on this).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with manifest.json and packages-lock.json

fernando-cortez
fernando-cortez requested changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well! And as Sam has mentioned, I believe only IPPopup.prefab needed to be modified in this PR.

@fernando-cortez fernando-cortez added the 2-Reviewed with Comments PR requires owner's attention label Sep 28, 2022
@SamuelBellomo SamuelBellomo added DO NOT MERGE Do not merge this PR! and removed DO NOT MERGE Do not merge this PR! labels Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo left review comments

@fernando-cortez fernando-cortez fernando-cortez requested changes

@jilfranco-unity jilfranco-unity Awaiting requested review from jilfranco-unity

Requested changes must be addressed to merge this pull request.

Assignees

@MorwennaG MorwennaG

Labels
2-Easy This PR is trivial and can be reviewed quickly 2-Reviewed with Comments PR requires owner's attention priority:medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MorwennaG @SamuelBellomo @fernando-cortez