Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improvements to child scene loader #704

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

SamuelBellomo
Copy link
Contributor

@SamuelBellomo SamuelBellomo commented Aug 2, 2022

Description

Removing config object from builds and scene hierarchy. They are now only editable through menu. (still saved in scene, but invisible). This way there's no more garbage in game scenes and this config is still saved per scene.

Adding automatic expand of child scenes when loading root scene.

Issue Number(s)

TODO

  • Utilities uses the word "boss room" its menu, this isn't great for something that should be reusable.

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

…only editable through menu. (still saved in scene, but invisible). This way there's no more garbage in game scenes and this config is still saved per scene.

Adding automatic expand of child scenes when loading root scene.
@SamuelBellomo SamuelBellomo added the 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. label Sep 23, 2022
@SamuelBellomo SamuelBellomo removed the 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant