Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated server support first pass - part 2/2 New DGS flow [MTT-1936] #696

Draft
wants to merge 17 commits into
base: sam/feat/dedicated-server-support-review/1-manual-stripping
Choose a base branch
from

Conversation

SamuelBellomo
Copy link
Contributor

@SamuelBellomo SamuelBellomo commented Jul 22, 2022

Description

This PR adds the new flows necessary for boss room to start a dedicated server.
This adds

  • A new scene to bypass the main menu and new connection states. server character selection scene is now managed automatically when finishing a game.
  • Adding command line args for Multiplay hosting.
  • Prevent closing lobby if no player is in it in DGS mode.
  • Adding flow post game to automatically bring everyone back to char select.
  • This also adds instructions for users for logging.
  • WaitForServerStarted is introduced as a new pattern to help alleviate callback hell.
    • --> this is reeaaally open to design discussions, I'm not super attached to this.

This is a simplified branch to help with review. Original work branch for history purposes: origin/sam/feat/dedicated-server-support

TODO SAM before merging this

  • add tests after LP's connection management tests are merged.
  • add full flow tests like we're doing with host tests, to at least check that we can start a DGS
  • add tests for WaitForServerStarted
  • add doc for WaitForServerStarted
  • add new doc or instructions for how to setup boss room with DGS

Issue Number(s)

MTT-1936

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

…ping' into sam/feat/dedicated-server-support-review/2-new-DGS-flow

* sam/feat/dedicated-server-support-review/1-manual-stripping:
  better file move
…ping' into sam/feat/dedicated-server-support-review/2-new-DGS-flow

* sam/feat/dedicated-server-support-review/1-manual-stripping:
  updated changelog
@SamuelBellomo SamuelBellomo added the 1-Needs Review PR needs attention from the assignee and reviewers label Jul 22, 2022
@SamuelBellomo SamuelBellomo marked this pull request as ready for review July 28, 2022 14:41
@SamuelBellomo SamuelBellomo added the DO NOT MERGE Do not merge this PR! label Aug 3, 2022
@SamuelBellomo SamuelBellomo added 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. and removed 1-Needs Review PR needs attention from the assignee and reviewers DO NOT MERGE Do not merge this PR! labels Sep 9, 2022
@SamuelBellomo SamuelBellomo reopened this Oct 14, 2022
@SamuelBellomo SamuelBellomo marked this pull request as draft October 14, 2022 18:15
@LPLafontaineB LPLafontaineB requested review from RikuTheFuffs and removed request for RikuTheFuffs August 29, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants