Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude third-party libs from coverage statistics #2282

Merged
merged 6 commits into from
Jun 23, 2023
Merged

Exclude third-party libs from coverage statistics #2282

merged 6 commits into from
Jun 23, 2023

Conversation

sofurihafe
Copy link
Member

@sofurihafe sofurihafe commented Jun 13, 2023 •
edited
Loading

Description

This PR improves minimization process in Spring-specific integration test generation process by excluding third-party and standard java lib instructions from coverage analysis. This fixes duplicate tests.

Fixes #2218

How to test

  1. Use spring-boot-testing project
  2. Enable 100% fuzzer
  3. Generate integration tests with configuration for OrderService.createOrder method

Manual tests

Tested on ilya_m/ilya_m/spring_integration_test_prototype branch. There are two instead of >8 tests.

@sofurihafe sofurihafe force-pushed the andrey-t/no_third_party_coverage branch from 3eb345e to 8c34155 Compare June 13, 2023 12:37
@sofurihafe sofurihafe added ctg-enhancement New feature, improvement or change request comp-spring Issue is related to Spring projects support comp-minimizer Issue is related to Minimization phase labels Jun 13, 2023
IlyaMuravjov
IlyaMuravjov reviewed Jun 13, 2023
View reviewed changes
utbot-framework-api/src/main/kotlin/org/utbot/framework/plugin/api/Api.kt Outdated Show resolved Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/plugin/api/TestCaseGenerator.kt Outdated Show resolved Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/plugin/api/TestCaseGenerator.kt Outdated Show resolved Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/plugin/api/TestCaseGenerator.kt Outdated Show resolved Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/plugin/api/TestCaseGenerator.kt Outdated Show resolved Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/plugin/api/TestCaseGenerator.kt Outdated Show resolved Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/plugin/api/TestCaseGenerator.kt Outdated Show resolved Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/plugin/api/TestCaseGenerator.kt Outdated Show resolved Hide resolved
@sofurihafe sofurihafe force-pushed the andrey-t/no_third_party_coverage branch 2 times, most recently from 2674893 to 5ff573c Compare June 14, 2023 10:35
@sofurihafe sofurihafe marked this pull request as ready for review June 14, 2023 10:45
@sofurihafe sofurihafe force-pushed the andrey-t/no_third_party_coverage branch from 5ff573c to 5678d22 Compare June 14, 2023 12:49
@sofurihafe sofurihafe force-pushed the andrey-t/no_third_party_coverage branch 2 times, most recently from 97417f1 to 6d76cbd Compare June 16, 2023 14:20
@sofurihafe sofurihafe marked this pull request as draft June 19, 2023 09:40
@sofurihafe sofurihafe force-pushed the andrey-t/no_third_party_coverage branch from c85d47c to 3b78cf0 Compare June 22, 2023 15:44
@sofurihafe sofurihafe marked this pull request as ready for review June 22, 2023 15:45
@sofurihafe sofurihafe force-pushed the andrey-t/no_third_party_coverage branch from 3b78cf0 to f7dc402 Compare June 23, 2023 10:11
@EgorkaKulikov EgorkaKulikov self-requested a review June 23, 2023 10:18
@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) June 23, 2023 10:19
@sofurihafe sofurihafe force-pushed the andrey-t/no_third_party_coverage branch from f7dc402 to 3a53bb4 Compare June 23, 2023 10:19
@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) June 23, 2023 10:21
@EgorkaKulikov EgorkaKulikov merged commit 7f914af into main Jun 23, 2023
@EgorkaKulikov EgorkaKulikov deleted the andrey-t/no_third_party_coverage branch June 23, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorkaKulikov EgorkaKulikov EgorkaKulikov approved these changes

@IlyaMuravjov IlyaMuravjov Awaiting requested review from IlyaMuravjov

Assignees
No one assigned
Labels
comp-minimizer Issue is related to Minimization phase comp-spring Issue is related to Spring projects support ctg-enhancement New feature, improvement or change request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate the behavior of Spring integration testing coverage calculation and minimization
3 participants
@sofurihafe @EgorkaKulikov @IlyaMuravjov