External variables support (closes #514) #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lana243
force-pushed
the
Lana243/extern-vars
branch
from
58da6a0
to
b7c3833
Compare
|
Seems currenly we get a problem with tests |
Lana243
force-pushed
the
Lana243/extern-vars
branch
from
50d9e17
to
467a2c6
Compare
Lana243
requested review from
sava-cska
and removed request for
alexey-utkin
ladisgin
requested changes
Nov 24, 2022
server/src/printers/KleePrinter.cpp
Outdated
| @@ -143,6 +143,15 @@ fs::path KleePrinter::writeTmpKleeFile( | |||
|
|
|||
| writeAccessPrivateMacros(typesHandler, tests, false); | |||
|
|
|||
| CollectionUtils::apply(tests.externVariables, [this](const Tests::TypeAndVarName &var) { | |||
There was a problem hiding this comment.
Same as server/src/printers/TestsPrinter.cpp:66
server/src/printers/KleePrinter.cpp
Outdated
| @@ -143,6 +143,15 @@ fs::path KleePrinter::writeTmpKleeFile( | |||
|
|
|||
| writeAccessPrivateMacros(typesHandler, tests, false); | |||
|
|
|||
| CollectionUtils::apply(tests.externVariables, [this](const Tests::TypeAndVarName &var) { | |||
ladisgin
approved these changes
Nov 28, 2022
sava-cska
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #514
To fix the problem extern variable declaration was added to KLEE wrapper and gtest file.