Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fields on 'Server Setup' page of wizard are misaligned #530

Closed
tyuldashev opened this issue Nov 9, 2022 · 4 comments · Fixed by #537
Closed

Fields on 'Server Setup' page of wizard are misaligned #530

tyuldashev opened this issue Nov 9, 2022 · 4 comments · Fixed by #537
Assignees
@alexey-utkin
Labels
bug Something isn't working verified Bug fix is verified vscode-plugin Issue related to VScode plugin

Comments

@tyuldashev
Copy link
Collaborator

To Reproduce
Steps to reproduce the behavior:

  1. Start 'Run UTBot: Quickstart` wizard
  2. Proceed to Server setup page

Actual behavior
Fields and labels are misaligned

image

Expected behavior

  • Host, GRPC port and SFTP port are start at the same horizontal position. Now it seems that port settings are more to the right than Host
  • Input fields for Host, GRPC port and SFTP port are start at the same horizontal position no matter of the length of label
  • Messages Successfully pinged... are the same vertical position as ports labels, now they are more the top than labels
@tyuldashev tyuldashev added the bug Something isn't working label Nov 9, 2022
@ladisgin ladisgin added the vscode-plugin Issue related to VScode plugin label Nov 11, 2022
alexey-utkin added a commit that referenced this issue Nov 14, 2022
@alexey-utkin
Fixes for #533, #530, #529 (partially), #528
566d633 
- SFTP notifications have wrong icons #533
- Fields on 'Server Setup' page of wizard are misaligned #530
- Wizard has no 'Previous' buttons #528
- Don't delete existing sftp.json configuration file #529 (partially - for user config we make a backup)

Signed-off-by: Alexey Utkin <[email protected]>
@alexey-utkin alexey-utkin mentioned this issue Nov 14, 2022
Merged
@alexey-utkin alexey-utkin linked a pull request Nov 14, 2022 that will close this issue
Fixes for #533, #530, #529 (partially), #528 #537
Merged
alexey-utkin added a commit that referenced this issue Nov 15, 2022
@alexey-utkin
Fixes for #533, #530, #529 (partially), #528 PR(#537)
59b658f 
- SFTP notifications have wrong icons #533
- Fields on 'Server Setup' page of wizard are misaligned #530
- Wizard has no 'Previous' buttons #528
- Don't delete existing sftp.json configuration file #529 (partially - for user config we make a backup)
@tyuldashev
Copy link
Collaborator Author

To be honest I don't see many changes in v2022.10.8, all the mentioned problems are still there
image

@alexey-utkin
Copy link
Collaborator

alexey-utkin commented Nov 17, 2022 •
edited
Loading

@tyuldashev
"GRPC Port" and "SFTP Port" are now right aligned.
The input and info cells are also aligned.
I don't want to align info vertically, because it can be multiline (for the case of different versions).

@tyuldashev
Copy link
Collaborator Author

tyuldashev commented Nov 17, 2022 •
edited
Loading

@alexey-utkin I see, though my suggestion was to left align all three labels and all three fields, note that Host and ports are started at different position.

@alexey-utkin
Copy link
Collaborator

@tyuldashev I think that it is ok.
Ports are "dependant" params for the host. So it is good to have an indent for them.

@tyuldashev tyuldashev added the verified Bug fix is verified label Nov 21, 2022
Lana243 pushed a commit that referenced this issue Nov 21, 2022
@alexey-utkin @Lana243
Fixes for #533, #530, #529 (partially), #528 PR(#537)
c0569df 
- SFTP notifications have wrong icons #533
- Fields on 'Server Setup' page of wizard are misaligned #530
- Wizard has no 'Previous' buttons #528
- Don't delete existing sftp.json configuration file #529 (partially - for user config we make a backup)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexey-utkin alexey-utkin

Labels
bug Something isn't working verified Bug fix is verified vscode-plugin Issue related to VScode plugin
Projects
UTBot C/C++
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for #533, #530, #529 (partially), #528 UnitTestBot/UTBotCpp
3 participants
@alexey-utkin @tyuldashev @ladisgin