Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support zora #584

Merged
merged 6 commits into from
May 21, 2024
Merged

feat: support zora #584

merged 6 commits into from
May 21, 2024

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented May 21, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    we don't support routing in Zora

  • What is the new behavior (if this is a feature change)?
    we will support routing in Zora

  • Other information:

Copy link
Member Author

jsy1218 commented May 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsy1218 and the rest of your teammates on Graphite Graphite

@jsy1218 jsy1218 marked this pull request as ready for review May 21, 2024 03:28
@jsy1218 jsy1218 requested a review from a team as a code owner May 21, 2024 03:28
@graphite-app graphite-app bot requested review from mikeki and cgkol May 21, 2024 03:28
Copy link

graphite-app bot commented May 21, 2024

Graphite Automations

"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (05/21/24)

3 reviewers were added and 1 assignee was added to this PR based on 's automation.

Copy link
Contributor

@cgkol cgkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tested?

Copy link
Member Author

jsy1218 commented May 21, 2024

Have we tested?

So I know the WETH/USDzC V3 pool liquidity is inefficient for routing, so I asked Zora folk to help add more liquidities

I mispoke. Turns out there's a liquid WETH/USDcZ v3 pool.

I tested in my local, and they all passed https://app.warp.dev/block/79q8d7nUzP6uekUqRcCNLE. We will need to update SOR repo to include JSON_RPC_PROVIDER_ZORA secret, but can wait until @mikeki is back.

@jsy1218 jsy1218 merged commit 3da2f26 into main May 21, 2024
19 of 25 checks passed
@jsy1218 jsy1218 deleted the jsy1218/support-zora branch May 21, 2024 23:58
@jsy1218 jsy1218 mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants