chore: onchain quoter batch param differed by optimistic cached routes #570
+41
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* return gas used from multicall in case of a failed quote * fix compiling error * add target contract address to the failed multicall debug log * also return gas limit
jsy1218
force-pushed
the
jsy1218/onchain-quoter-batch-param-differed-by-optimistic-cached-routes
branch
from
aca7fdc
to
44b1d69
Compare
Graphite Automations"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (05/10/24)3 reviewers were added and 1 assignee was added to this PR based on 's automation. |
mikeki
approved these changes
May 10, 2024
jsy1218
deleted the
jsy1218/onchain-quoter-batch-param-differed-by-optimistic-cached-routes
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore
What is the current behavior? (You can also link to an open issue here)
We don't differ gas batch param by intent-quote vs caching-quote.
What is the new behavior (if this is a feature change)?
We will differentiate
Other information: