fix: missing chains for outside of same map config #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeki
approved these changes
Apr 22, 2024
jsy1218
deleted the
jsy1218/fix-missing-new-quoter-address-across-chains
branch
Merged
jsy1218
added a commit
that referenced
this pull request
Apr 23, 2024
jsy1218
added a commit
that referenced
this pull request
May 9, 2024
- **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) Bug fix - **What is the current behavior?** (You can also link to an open issue here) I was reviewing onchain quote provider config, and realized the same config map only contains Polygon. I populated for all networks to be safe for future references. Also I realized the [NETWORKS_WITH_SAME_UNISWAP_ADDRESSES](https://github.com/Uniswap/smart-order-router/blob/f73799d8025bddfea725df93f9dad6ecbe895d62/src/util/chains.ts#L53) doesn't contain all the production networks, so I need to manually populate them to be extra safe. - **What is the new behavior (if this is a feature change)?** Add the missing chains for the same config mapping. - **Other information**:
jsy1218
added a commit
that referenced
this pull request
May 9, 2024
jsy1218
added a commit
that referenced
this pull request
May 9, 2024
- **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) Bug fix - **What is the current behavior?** (You can also link to an open issue here) I was reviewing onchain quote provider config, and realized the same config map only contains Polygon. I populated for all networks to be safe for future references. Also I realized the [NETWORKS_WITH_SAME_UNISWAP_ADDRESSES](https://github.com/Uniswap/smart-order-router/blob/f73799d8025bddfea725df93f9dad6ecbe895d62/src/util/chains.ts#L53) doesn't contain all the production networks, so I need to manually populate them to be extra safe. - **What is the new behavior (if this is a feature change)?** Add the missing chains for the same config mapping. - **Other information**:
jsy1218
added a commit
that referenced
this pull request
May 9, 2024
jsy1218
added a commit
that referenced
this pull request
May 10, 2024
- **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) Bug fix - **What is the current behavior?** (You can also link to an open issue here) I was reviewing onchain quote provider config, and realized the same config map only contains Polygon. I populated for all networks to be safe for future references. Also I realized the [NETWORKS_WITH_SAME_UNISWAP_ADDRESSES](https://github.com/Uniswap/smart-order-router/blob/f73799d8025bddfea725df93f9dad6ecbe895d62/src/util/chains.ts#L53) doesn't contain all the production networks, so I need to manually populate them to be extra safe. - **What is the new behavior (if this is a feature change)?** Add the missing chains for the same config mapping. - **Other information**:
jsy1218
added a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
I was reviewing onchain quote provider config, and realized the same config map only contains Polygon. I populated for all networks to be safe for future references. Also I realized the NETWORKS_WITH_SAME_UNISWAP_ADDRESSES doesn't contain all the production networks, so I need to manually populate them to be extra safe.
What is the new behavior (if this is a feature change)?
Add the missing chains for the same config mapping.
Other information: