fix: improve quote provider logging & update sepolia quoter address #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeki
reviewed
Apr 22, 2024
mikeki
approved these changes
Apr 22, 2024
Merged
jsy1218
added a commit
to Uniswap/routing-api
that referenced
this pull request
Apr 22, 2024
We want to be able to different the quoter protocol version by explicitly adding the `Mixed` vs `V3` metrics wording. This is done primary through SOR Uniswap/smart-order-router#547
jsy1218
added a commit
that referenced
this pull request
Apr 22, 2024
- **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) Release #547
jsy1218
added a commit
that referenced
this pull request
May 9, 2024
…547) * improve quote provider logging * fix minor string placeholder * revert unintended lodash import * revert unintended lodash import * add override quoter address definedness check to be consistent
jsy1218
added a commit
that referenced
this pull request
May 9, 2024
- **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) Release #547
jsy1218
added a commit
that referenced
this pull request
May 9, 2024
…547) * improve quote provider logging * fix minor string placeholder * revert unintended lodash import * revert unintended lodash import * add override quoter address definedness check to be consistent
jsy1218
added a commit
that referenced
this pull request
May 9, 2024
- **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) Release #547
jsy1218
added a commit
that referenced
this pull request
May 10, 2024
…547) * improve quote provider logging * fix minor string placeholder * revert unintended lodash import * revert unintended lodash import * add override quoter address definedness check to be consistent
jsy1218
added a commit
that referenced
this pull request
May 10, 2024
- **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) Release #547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Our quote provider logging doesn't differentiate between mixed quoter and v3 quoter. We should differentiate them for better perf analysis.
Also the sepolia quoter address has to be updated because it was using the wrong v3 factory address.
What is the new behavior (if this is a feature change)?
Enrich the quote provider logging with the mixed quoter vs v3 quoter.
Other information: