Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:add new view quoter address on blast #545

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Apr 19, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    Unfortunately Blast Quoter has a different deployed address than most chains. This is because even a forge dryrun (add blast into foundry map view-quoter-v3#16) on blast mainnet can cause the nonce to increment:

Screenshot 2024-04-19 at 11 45 37 AM Screenshot 2024-04-19 at 11 45 43 AM
  • What is the new behavior (if this is a feature change)?
    We have to update blast quoter address to a new address corresponding to nonce 2:
Screenshot 2024-04-19 at 11 46 30 AM
  • Other information:

@jsy1218 jsy1218 self-assigned this Apr 19, 2024
@jsy1218 jsy1218 requested a review from a team as a code owner April 19, 2024 18:46
@jsy1218 jsy1218 merged commit dc238d2 into main Apr 19, 2024
23 of 24 checks passed
@jsy1218 jsy1218 deleted the jsy1218/add-new-view-quoter-address-on-blase branch April 19, 2024 18:50
jsy1218 added a commit that referenced this pull request May 9, 2024
jsy1218 added a commit that referenced this pull request May 9, 2024
jsy1218 added a commit that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants