chore: use single default view-only quoter deploy address #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rollingtumbling
approved these changes
Apr 18, 2024
jsy1218
deleted the
jsy1218/view-only-quoter-single-default-deploy-address
branch
Merged
jsy1218
added a commit
that referenced
this pull request
Apr 19, 2024
jsy1218
added a commit
that referenced
this pull request
May 9, 2024
jsy1218
added a commit
that referenced
this pull request
May 9, 2024
jsy1218
added a commit
that referenced
this pull request
May 9, 2024
jsy1218
added a commit
that referenced
this pull request
May 9, 2024
jsy1218
added a commit
that referenced
this pull request
May 10, 2024
jsy1218
added a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore
What is the current behavior? (You can also link to an open issue here)
Since we are using the same deployer wallet to deploy, most likely the first deployed address will be the same across chains. We are enumerating the view-only quoter address for now.
What is the new behavior (if this is a feature change)?
We don't enumerate the view-only quoter address per chain, unless that particular chain has a different deploy address. This will speed up our new chain deploy, where we can just ship changes in routing-api for each newly deployed quoter on a new chain.
Other information: