chore: ban ethers (#82)

* fix: auto lint * fix: ban ethers imports * Fix code style issues with Prettier * fix: use ethers for typings Co-authored-by: Lint Action <[email protected]>
Uniswap · Mar 28, 2022 · b1e311f · b1e311f
1 parent 6f230bf
commit b1e311f
Show file tree

Hide file tree

Showing 37 changed files with 997 additions and 1,047 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -28,6 +28,17 @@
  "sort-imports": [
  "error",
  { "ignoreDeclarationSort": true, "ignoreCase": true }
+ ],
+ "no-restricted-imports": [
+ "error",
+ {
+ "paths": [
+ {
+ "name": "ethers",
+ "message": "Please import from '@ethersproject/module' directly to support tree-shaking."
+ }
+ ]
+ }
  ]
  }
 }
diff --git a/cli/base-command.ts b/cli/base-command.ts
@@ -1,12 +1,13 @@
 /// <reference types="./types/bunyan-debug-stream" />
+import { BigNumber } from '@ethersproject/bignumber';
+import { JsonRpcProvider } from '@ethersproject/providers';
 import { Command, flags } from '@oclif/command';
 import { ParserOutput } from '@oclif/parser/lib/parse';
 import DEFAULT_TOKEN_LIST from '@uniswap/default-token-list';
 import { Currency, CurrencyAmount, Token } from '@uniswap/sdk-core';
 import { MethodParameters } from '@uniswap/v3-sdk';
 import bunyan, { default as Logger } from 'bunyan';
 import bunyanDebugStream from 'bunyan-debug-stream';
-import { BigNumber, ethers } from 'ethers';
 import _ from 'lodash';
 import NodeCache from 'node-cache';
 import {
@@ -212,10 +213,7 @@ export abstract class BaseCommand extends Command {
  const chainId = ID_TO_CHAIN_ID(chainIdNumb);
  const chainProvider = ID_TO_PROVIDER(chainId);
 
- const provider = new ethers.providers.JsonRpcProvider(
- chainProvider,
- chainId
- );
+ const provider = new JsonRpcProvider(chainProvider, chainId);
  this._blockNumber = await provider.getBlockNumber();
 
  const tokenCache = new NodeJSCache<Token>(

diff --git a/cli/commands/quote-to-ratio.ts b/cli/commands/quote-to-ratio.ts
@@ -1,8 +1,8 @@
+import { Logger } from '@ethersproject/logger';
 import { flags } from '@oclif/command';
 import { Currency, Ether, Fraction, Percent } from '@uniswap/sdk-core';
 import { Position } from '@uniswap/v3-sdk';
 import dotenv from 'dotenv';
-import { ethers } from 'ethers';
 import {
  ID_TO_CHAIN_ID,
  parseAmount,
@@ -13,8 +13,8 @@ import { BaseCommand } from '../base-command';
 
 dotenv.config();
 
-ethers.utils.Logger.globalLogger();
-ethers.utils.Logger.setLogLevel(ethers.utils.Logger.levels.DEBUG);
+Logger.globalLogger();
+Logger.setLogLevel(Logger.levels.DEBUG);
 
 export class QuoteToRatio extends BaseCommand {
  static description = 'Uniswap Smart Order Router CLI';

diff --git a/cli/commands/quote.ts b/cli/commands/quote.ts
@@ -1,8 +1,8 @@
+import { Logger } from '@ethersproject/logger';
 import { flags } from '@oclif/command';
 import { Protocol } from '@uniswap/router-sdk';
 import { Currency, Percent, TradeType } from '@uniswap/sdk-core';
 import dotenv from 'dotenv';
-import { ethers } from 'ethers';
 import _ from 'lodash';
 import {
  ID_TO_CHAIN_ID,
@@ -16,8 +16,8 @@ import { BaseCommand } from '../base-command';
 
 dotenv.config();
 
-ethers.utils.Logger.globalLogger();
-ethers.utils.Logger.setLogLevel(ethers.utils.Logger.levels.DEBUG);
+Logger.globalLogger();
+Logger.setLogLevel(Logger.levels.DEBUG);
 
 export class Quote extends BaseCommand {
  static description = 'Uniswap Smart Order Router CLI';