Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wstETH/DOG manually included in subgraph pool #778

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Jul 9, 2024

wstETH/DOG subgraph returns 0 reserve:

Screenshot 2024-07-09 at 11.20.24 PM.png

It gets filtered out https://github.com/Uniswap/smart-order-router/blob/main/src/providers/v2/subgraph-provider.ts#L251.

We now will include wstETH/DOG pool manually in routing

Copy link
Member Author

jsy1218 commented Jul 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsy1218 and the rest of your teammates on Graphite Graphite

@jsy1218 jsy1218 marked this pull request as ready for review July 9, 2024 22:09
@graphite-app graphite-app bot requested review from cgkol, mikeki, a team and uni-guillaume July 9, 2024 22:13
@graphite-app graphite-app bot requested review from xrsv and removed request for uni-guillaume July 9, 2024 22:13
Copy link

graphite-app bot commented Jul 9, 2024

Graphite Automations

"Request reviewers once CI passes on routing-api repo" took an action on this PR • (07/09/24)

6 reviewers were added and 1 assignee was added to this PR based on 's automation.

Copy link
Member Author

@jsy1218 jsy1218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local testing shows now the pool can get routed: https://app.warp.dev/block/QgVZ76pO4si3I1b3WdNEQ3

@jsy1218 jsy1218 merged commit 2632d96 into main Jul 9, 2024
5 checks passed
@jsy1218 jsy1218 deleted the jsy1218/wstETH/DOG-subgraph-pool-routing branch July 9, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants