Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement quicknode geth vs reth output comparison #775

Merged
merged 9 commits into from
Jul 15, 2024
+313 −7
Merged

feat: implement quicknode geth vs reth output comparison #775

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f03ebdf
feat: implement quicknode geth vs reth output comparison
jsy1218 Jul 1, 2024
8a6f112
feat: implement quicknode geth vs reth output comparison
jsy1218 Jul 2, 2024
31aabe0
fic prettier
jsy1218 Jul 2, 2024
1a5dd5e
feedbacks
jsy1218 Jul 3, 2024
8178083
fix prettier
jsy1218 Jul 3, 2024
ba0393b
fix the send method comparison
jsy1218 Jul 5, 2024
1a76072
send method ethers library returns the result as is based on the lib …
jsy1218 Jul 15, 2024
e393fff
send method ethers library returns the result as is based on the lib …
jsy1218 Jul 15, 2024
76b6255
complete unit test coverage
jsy1218 Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fic prettier
  • Loading branch information
@jsy1218
jsy1218 committed Jul 15, 2024
commit 31aabe0094a7e28ecb7371ebccb9761c53b90863
4 changes: 1 addition & 3 deletions lib/rpc/UniJsonRpcProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,9 +314,7 @@ export class UniJsonRpcProvider extends StaticJsonRpcProvider {
if (serializedProviderResponse !== serializedEvaluatedProviderResponse) {
this.log.error(
{ methodName, args },
`Provider response mismatch: ${serializedProviderResponse} from ${
selectedProvider.providerId
} vs ${serializedEvaluatedProviderResponse} from ${otherProvider.providerId}`
`Provider response mismatch: ${serializedProviderResponse} from ${selectedProvider.providerId} vs ${serializedEvaluatedProviderResponse} from ${otherProvider.providerId}`
)
selectedProvider.logRpcResponseMismatch(methodName, otherProvider)
} else {
Expand Down