Log optimistic cached routes on-chain quoting metrics #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mikeki
approved these changes
May 9, 2024
…-in-onchain-quoter
jsy1218
deleted the
jsy1218/log-optimistic-cached-routes-metrics-in-onchain-quoter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i was looking at routing dashboard. I can see caching intent quote latency is improving on Blast after gas param tuning, but not quote intent quote latency:
This tells me we need to tune the gas param for quote-intent onchain quoting more aggressively. Right now we don't distinguish the metrics between quote-intent vs caching-intent metrics in onchain quoting. We will do so by bumping SOR Uniswap/smart-order-router#568