feat: live switch optimism quote for 100 percent #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jsy1218
changed the title
graphite-app
bot
requested review from
rollingtumbling,
cgkol,
a team and
mikeki
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (04/25/24)5 reviewers were added to this PR based on 's automation. |
Sorry still working on it. Im actually using Graphite to create PR now. Graphite will automatically create a draft PR with empty description, so Im adding the description right now. |
@cgkol done |
cgkol
approved these changes
Apr 25, 2024
jsy1218
force-pushed
the
jsy1218/live-switch-optimism-quote-for-100-percent
branch
from
19d4458
to
67ced9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check the following metrics before we decide to increase traffic switch on Optimism:
Is Optimism live traffic switched at 1%?
Based on the metrics, this appears to be the same:
Is the success rate on the Optimism endpoint?
Optimism endpoint shows the consistently high success rate:
Is the latency on the Optimism endpoint consistent?
Optimism latency actually went down a while after live switch, but I think this is due to the RPC call latency improvement:
Is the RPC call volume only slightly up after quote shadow sampling on Optimism?
Optimism RPC call volume only shows minimum increase, which is important because when we live switch, we don't expect to see any further more RPC calls due to our optimized implementations: