Support More Web3 Providers #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghava-pamula
force-pushed
the
Raghava/feature1-Support_More_Web3_Providers
branch
from
efee6f6
to
5c78503
Compare
willpote
reviewed
Jun 2, 2022
lib/handlers/injector-sor.ts
Outdated
Comment on lines
118
to
121
| case 'alchemy': | ||
| // todo: add logic to generate alchemy rpc urls | ||
| case 'moralis': | ||
| // todo: todo: add logic to generate moralis rpc urls |
There was a problem hiding this comment.
Could you fill in alchemy just so its ready if we need to switch out?
Think we can remove moralis too for now
marktoda
reviewed
Jun 2, 2022
lib/handlers/injector-sor.ts
Outdated
| case 'moralis': | ||
| // todo: todo: add logic to generate moralis rpc urls | ||
| default: | ||
| throw Error('Fatal: Unknown Provider Not Supported') |
There was a problem hiding this comment.
Should default be infura to keep old behavior if no provider_name set?
raghava-pamula
force-pushed
the
Raghava/feature1-Support_More_Web3_Providers
branch
from
bb54087
to
61eb791
Compare
raghava-pamula
force-pushed
the
Raghava/feature1-Support_More_Web3_Providers
branch
from
ac5d3bf
to
27aa63d
Compare
raghava-pamula
force-pushed
the
Raghava/feature1-Support_More_Web3_Providers
branch
from
2577323
to
c2be7fb
Compare
|
Integ tests are failing :'( |
raghava-pamula
force-pushed
the
Raghava/feature1-Support_More_Web3_Providers
branch
from
4962f92
to
430687e
Compare
raghava-pamula
force-pushed
the
Raghava/feature1-Support_More_Web3_Providers
branch
from
a6509db
to
d5a8ef4
Compare
raghava-pamula
force-pushed
the
Raghava/feature1-Support_More_Web3_Providers
branch
from
353ef73
to
08634ae
Compare
raghava-pamula
force-pushed
the
Raghava/feature1-Support_More_Web3_Providers
branch
from
fbd5666
to
70fc8ea
Compare
willpote
suggested changes
Jun 5, 2022
bin/app.ts
Outdated
| let jsonRpcProviders = {} as { [chainId: string]: string } | ||
| SUPPORTED_CHAINS.forEach((chainId: ChainId) => { | ||
| const key = `WEB3_RPC_${chainId}` | ||
| jsonRpcProviders[key] = jsonRpcProvidersSecret.secretValueFromJson(key) as unknown as string |
There was a problem hiding this comment.
Use .toString() like we do below
Comment on lines
+219
to
+238
| WEB3_RPC_1: process.env.WEB3_RPC_1!, | ||
| WEB3_RPC_3: process.env.WEB3_RPC_3!, | ||
| WEB3_RPC_4: process.env.WEB3_RPC_4!, | ||
| WEB3_RPC_5: process.env.WEB3_RPC_5!, | ||
| WEB3_RPC_42: process.env.WEB3_RPC_42!, | ||
| WEB3_RPC_10: process.env.WEB3_RPC_10!, | ||
| WEB3_RPC_69: process.env.WEB3_RPC_69!, | ||
| WEB3_RPC_42161: process.env.WEB3_RPC_42161!, | ||
| WEB3_RPC_421611: process.env.WEB3_RPC_421611!, | ||
| WEB3_RPC_137: process.env.WEB3_RPC_137!, | ||
| WEB3_RPC_80001: process.env.WEB3_RPC_80001!, | ||
| }, |
There was a problem hiding this comment.
Can you update the package README so people know to do this?
lib/handlers/injector-sor.ts
Outdated
| const projectId = process.env.PROJECT_ID | ||
| const url = `https://${chainName}.infura.io/v3/${projectId}` | ||
| const url = process.env[`WEB3_RPC_${chainId.toString()}`]! | ||
| log.info({ url: url }, `GENERATED URL`) |
lib/handlers/injector-sor.ts
Outdated
| const url = process.env[`WEB3_RPC_${chainId.toString()}`]! | ||
| log.info({ url: url }, `GENERATED URL`) | ||
|
|
||
| if (typeof url == undefined || url == '') { |
bin/app.ts
Outdated
| const jsonRpcProvidersSecret = sm.Secret.fromSecretAttributes(this, 'RPCProviderUrls', { | ||
| secretCompleteArn: | ||
| 'arn:aws:secretsmanager:us-east-2:644039819003:secret:routing-api-rpc-urls-json-primary-ixS8mw', | ||
| //backup Arn: arn:aws:secretsmanager:us-east-2:644039819003:secret:routing-api-rpc-urls-json-backup-D2sWoe |
There was a problem hiding this comment.
Could you add a bit more context to this comment so other people know why this exists?
Also add a note that you must update the multicall chunk size to 50 for optimism when switching to the backup
raghava-pamula
force-pushed
the
Raghava/feature1-Support_More_Web3_Providers
branch
from
e8602e7
to
c8a9fe5
Compare
raghava-pamula
force-pushed
the
Raghava/feature1-Support_More_Web3_Providers
branch
from
683c6c7
to
8c5e06d
Compare
raghava-pamula
force-pushed
the
Raghava/feature1-Support_More_Web3_Providers
branch
from
06678d0
to
bb73b04
Compare
willpote
approved these changes
Jun 5, 2022
raghava-pamula
force-pushed
the
Raghava/feature1-Support_More_Web3_Providers
branch
from
3a58b18
to
8ab345b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Commit for adding support for web3 providers outside of infura. Currently, the project only supports infura web3 providers, and more flexibility is needed since infura has had outages.
#38