IPFS Pool Cache #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willpote
reviewed
Oct 4, 2021
willpote
reviewed
Oct 6, 2021
bin/stacks/routing-caching-stack.ts
Outdated
| @@ -37,6 +47,13 @@ export class RoutingCachingStack extends cdk.NestedStack { | |||
| ], | |||
| }); | |||
|
|
|||
| lambdaRole.addToPolicy( | |||
| new PolicyStatement({ | |||
| resources: [route53Arn!], | |||
There was a problem hiding this comment.
Does it still deploy if route53Arn is undefined? I think IAM does some basic validation of policies during deployment so I would expect the deployment to fail?
There was a problem hiding this comment.
Hm, I'm not sure.. should we make it a required variable?
There was a problem hiding this comment.
You can remove it from your .env and do a test deploy to see.
If it is required, you can just put this in an if (stage == Stage.beta)
There was a problem hiding this comment.
Yeah, we'd need to require the route53 arn so I just wrapped it in an if statement
lib/cron/cache-pools-ipfs.ts
Outdated
|
|
||
| // init route53 with credentials | ||
| let data; | ||
| var route53 = new Route53(); |
There was a problem hiding this comment.
changed to it let route53 since we redefine it below with the credentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkpointing the pool cache deploy on ipfs