Hardhat tests #25
Hardhat tests #25
Conversation
hardhat.config.js
Outdated
| defaultNetwork: 'hardhat', | ||
| networks: { | ||
| hardhat: { | ||
| blockGasLimit: 150_000_000, |
There was a problem hiding this comment.
this is bc 10x block gas limit for static calls??
There was a problem hiding this comment.
Actually this isn't needed since we don't do the static calls in the tests. This was copy pasted from another project where I was doing huge static calls. Will remove
hardhat.config.js
Outdated
| forking: { | ||
| enabled: true, | ||
| url: `${process.env.ARCHIVE_NODE_RPC}`, | ||
| blockNumber: 12972642, |
There was a problem hiding this comment.
hmm...is this for predictable test results?? wonder if there'd be a way to test things without needing exact numbers...haven't thought it through yet though
There was a problem hiding this comment.
Actually this was copy pasted over too and isn't needed.
The tests already don't require exact numbers. Currently I check the users balance before and after the swap
e.g. For example for an exactIn swap of 100, i check the user has 100 less of tokenIn after the swap. I don't check tokenOut, but thinking more about it- i think it would be valuable to check token out is within slippage percentage of the quote. Ill add some more checks
test/integ/quote.test.ts
Outdated
| percentDiff.denominator | ||
| }), quote: ${tokensQuoted.toExact()}, rceived: ${tokensSwapped.toExact()}` | ||
| ) */ | ||
| expect(percentDiff.lessThan(new Fraction(5, 100))).to.be.true |
There was a problem hiding this comment.
where does this figure come from??
Jest -> Mocha in order to make hardhat tests work.
Simulate swaps using hardhat fork for the quote integ tests