Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show hidden search results by default #1310

Merged
merged 6 commits into from
Feb 9, 2021
Merged

show hidden search results by default #1310

merged 6 commits into from
Feb 9, 2021

Conversation

ianlapham
Copy link
Member

  • replace button with list separator and always show inactive results

@vercel
Copy link

vercel bot commented Feb 9, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uniswap/uniswap-interface/k9l3ikoo8
✅ Preview: https://uniswap-interface-git-fork-ianlapham-main.uniswap.vercel.app

@JFrankfurt
Copy link
Contributor

Should debounce the text input; it's a little laggy right now because it's running the filters on every keystroke.

@ianlapham
Copy link
Member Author

ianlapham commented Feb 9, 2021 •
edited
Loading

Should debounce the text input; it's a little laggy right now because it's running the filters on every keystroke.

@JFrankfurt Added a 150ms debounce, think this feels alright?

@JFrankfurt
Copy link
Contributor

I've never really thought about what the right input debounce is. Interesting question. I just did some googling and saw someone calculate 167ms is the average time between keystrokes, so maybe we do a little more? Like 200ms?

@ianlapham
Copy link
Member Author

I've never really thought about what the right input debounce is. Interesting question. I just did some googling and saw someone calculate 167ms is the average time between keystrokes, so maybe we do a little more? Like 200ms?

Yeah I've seen 200 a lot. Ill update to this then merge. @JFrankfurt

@ianlapham ianlapham merged commit 76ab349 into Uniswap:main Feb 9, 2021
antron3000 added a commit to UdotCASH/u-exchange that referenced this pull request Feb 9, 2021
@antron3000
Merge pull request #1 from Uniswap/main
0e13805 
show hidden search results by default (Uniswap#1310)
daniel-dev1990 pushed a commit to daniel-dev1990/uniswap-interface that referenced this pull request Jul 8, 2021
@ianlapham
show hidden search results by default (Uniswap#1310)
e389325 
* show hidden search results by default

* update break styles

* optimize filter, use debounce on input

* increase debounce time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JFrankfurt JFrankfurt JFrankfurt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ianlapham @JFrankfurt