Remove FmrcCacheMonitor and FmrcController #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Unidata/netcdf-java#17, FMRCs no longer use an on disk persistence cache (now it's all in memory). This PR removes components of the TDS that focused on managing / monitoring that cache.
|
@JohnLCaron - would you say this looks about right? Any reason to refactor the showFmrc controller to display information about the in-memory cache? |
|
I'm going to go ahead and pull this in for the beta. We can revisit this if we need to do something different. |
|
Didnt see this until now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Unidata/netcdf-java#17, FMRCs no longer use an on disk persistence
cache (now it's all in memory). This PR removes components of the TDS
that focused on managing / monitoring that cache.