Update get_cache_folder for Windows #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 16, 2022 10:39
no need to explicit look for HOME env, because behind the scenes Path.home() will call os.path.expanduser, which will look for HOME env if it exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
get_cache_folderutility tries to rely on the envHOME. But this variable is not regularly set on Windows. Luckily Python comes with some cross-platform defaults to get a user's home directory.This PR makes a small update to use pathlib's
Path.home, which in turn will accessos.path.expanduser. Here, the user's home will be resolved. It will target theHOMEenv variable if it exists (as was implemented in COMET before) and otherwise it will try to find the user's home another way.This should make the code base more compatible with Windows, although I have not tested yet if this would make the whole lib work on Windows.