Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tosiewytnie.pl #55

Closed
xxcriticxx opened this issue Sep 19, 2017 · 10 comments
Closed

tosiewytnie.pl #55

xxcriticxx opened this issue Sep 19, 2017 · 10 comments
Assignees
Labels
false positive all false positive review requests

Comments

@xxcriticxx
Copy link

::: /etc/pihole/list.41.hosts.ubuntu101.co.za.domains (1 results)
0.0.0.0 tosiewytnie.pl

@mitchellkrogza
Copy link
Member

Thanks @xxcriticxx added to false positives on https://github.com/mitchellkrogza/CENTRAL-REPO.Dead.Inactive.Whitelisted.Domains.For.Hosts.Projects and will be stripped out on next build. Keep em coming 👍

@mitchellkrogza
Copy link
Member

@xxcriticxx @funilrys if either of you can think of any domains which should be permanently whitelisted always, please review the list here and either send a PR with more domains to be whitelisted or simply list them in Issues on that repo and I will add them.

@funilrys
Copy link
Member

@mitchellkrogza I didn't look into the code but do you use regex match? Cause for example:

It'll save us some bytes to have

  • google.com ==> can match dl.google.com and drive.google.com
  • apple.com ==> can match itunes.apple.com
  • cnn.com ==> can match money.cnn.com
  • ubuntu.com ==> can match archive.ubuntu.com

I don't know what you think about it but I think it can be great assuming that only legitimate (big company or well-known website) domains are on that whitelist.

@mitchellkrogza
Copy link
Member

I agree totally, haven't figured out a regex in my cleaning functions to handle that. Much better to have just root domains and then *.domain.com get's stripped out of hosts lists. Do you want to review those list cleaning functions for me ??? You're smarter with Regex than me 😁

@xxcriticxx
Copy link
Author

https://discourse.pi-hole.net/t/commonly-whitelisted-domains/212

@mitchellkrogza
Copy link
Member

@xxcriticxx we still have about another 5 days of dead domain testing to go before fresh links get pushed out again.

@xxcriticxx
Copy link
Author

@mitchellkrogza no problem!

@mitchellkrogza
Copy link
Member

199b042 Fix: #55

@mitchellkrogza
Copy link
Member

@xxcriticxx fresh raw links pushed out today. Continuation of dead domains testing continuing in a separate environment.

@funilrys funilrys self-assigned this Mar 16, 2018
@funilrys funilrys added the false positive all false positive review requests label Mar 16, 2018
@funilrys funilrys reopened this Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
false positive all false positive review requests
Projects
None yet
Development

No branches or pull requests

3 participants