Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking all LAN #508

Closed
unbranched opened this issue Mar 25, 2019 · 8 comments
Closed

Blocking all LAN #508

unbranched opened this issue Mar 25, 2019 · 8 comments
Assignees
Labels
bug false positive all false positive review requests

Comments

@unbranched
Copy link

It's included again

ALL: 192.168.0.0/16

@mitchellkrogza mitchellkrogza added bug false positive all false positive review requests labels Mar 25, 2019
@mitchellkrogza
Copy link
Member

@funilrys which input source is this coming in from? We need to create a permanent whitelist for all private networking ranges to avoid this creeping back in every now and again

@mitchellkrogza
Copy link
Member

10.0.0.0 to 10.255.255.255.
172.16.0.0 to 172.31.255.255.
192.168.0.0 to 192.168.255.255

funilrys added a commit to Ultimate-Hosts-Blacklist/whitelist that referenced this issue Mar 25, 2019
Also: Introduction of the tests in order to avoid such isssues in the future
funilrys added a commit that referenced this issue Mar 25, 2019
Because of #508 and its fix Ultimate-Hosts-Blacklist/whitelist@57f308e.

New data will be available in about 15 minutes.
@funilrys
Copy link
Member

Service Note: Had to restart the build because the wrong version of the whitelisting tool was installed. It is now the correct one. New data will be available in the next 10-15 minutes.

@funilrys
Copy link
Member

@mitchellkrogza firehol1

@unbranched
Copy link
Author

I will no longer report this

@funilrys
Copy link
Member

Thanks @unbranched, no need to.

Tests are written and will be improved with the time as you can see at Ultimate-Hosts-Blacklist/whitelist@57f308e#diff-91096435e85fc2eb752d068ef2758f5d.

It will now be checked before a release of a new version of the whitelisting tool.

Cheers,
Nissar

@funilrys
Copy link
Member

Closing. Not present anymore at https://raw.githubusercontent.com/mitchellkrogza/Ultimate.Hosts.Blacklist/master/superhosts.deny/superhosts7.deny:

ALL: 192.166.219.211
ALL: 192.166.219.43
ALL: 192.166.252.0/24
ALL: 192.166.81.0/24
ALL: 192.166.82.0/23
ALL: 192.167.119.200
ALL: 192.167.122.8
ALL: 192.167.155.70
ALL: 192.167.9.104
ALL: 192.169.136.33
ALL: 192.169.136.51
ALL: 192.169.138.33
ALL: 192.169.138.87
ALL: 192.169.140.100
ALL: 192.169.141.72
ALL: 192.169.143.36
ALL: 192.169.144.23
ALL: 192.169.146.53
ALL: 192.169.152.2
ALL: 192.169.153.42
ALL: 192.169.155.103
ALL: 192.169.155.230
ALL: 192.169.157.188
ALL: 192.169.171.149
ALL: 192.169.175.208

@funilrys
Copy link
Member

Just a side note @mitchellkrogza,

Since Ultimate-Hosts-Blacklist/whitelist@9c251b7, all reserved IPv4 are now whitelisted by the whitelisting tool.

Of course, tests shipped along with it to avoid future issues.

Cheers,
Nissar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug false positive all false positive review requests
Projects
None yet
Development

No branches or pull requests

3 participants