Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __init__.py #386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update __init__.py #386

wants to merge 1 commit into from

Conversation

brysonpayne
Copy link

Update to use new Bing credential and recognition URLs - Microsoft is phasing out Bing Speech API, moving to Cognitive Services Speech API. The two URLs changed in this fork will work for demo Speech API keys after 11/1/2018.

Update to use new Bing credential and recognition URLs - Microsoft is phasing out Bing Speech API, moving to Cognitive Services Speech API. The two URLs above work for demo Speech API keys after 11/1/2018.
@palikar
Copy link
Collaborator

palikar commented Nov 11, 2018

Hi @brysonpayne ,

thanks for the PR! I took a look at the new API. It seems that there are several regional endpoints. In your code, the used endpoint is the West US one. I assume, however, that the speech_recognition library is used by a lot (hopefully) people across the world. Would you be able to modify the `recognize_bing? method a little bit by adding an keyword argument so that different regional endpoints can be used. The values of the argument can then be "west", "eastus", "eastasia",.. etc. I guess the default should be "westus". Please, also don't forget to update the documentation.

Let me now if you are willing to do that. If you don't have the time, I can make the changes myself and I will still merge you PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants