Scholarship Screen Implementation Version 0.5 #39
Conversation
This reverts commit 47173a6.
Added elevation to App Bar
| List<String> secondary; | ||
| String result = ""; | ||
| try { | ||
| if(content.contains(":")){ |
There was a problem hiding this comment.
Looking at Heroku and this method, I can't help but think you are giving yourself unnecessary extra parsing work 💀 💀 .
^ The highlighted text is common to the entries in the database or can be made common which is kind of a waste, I think. You know already what these sections will start off with so you can just add the relevant information (the unhighlighted text) to them in the app. These aren't the only fields this applies to though; any of the fields that would have bullets under them.
Also, I did say to make it so that you have a list for each field that you can iterate through. In Django, a list for a field can be achieved like this. In this class, the respective fields would be of type List<String>. I'm sure it will shorten your code significantly and make it easier to understand and maintain.
| List<String> secondary; | ||
|
|
||
| try { | ||
| if(content.contains(":")){ |
There was a problem hiding this comment.
See the parsing here again.
No description provided.