added a translate command #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mole1424
reviewed
Apr 1, 2024
cogs/commands/misc.py
Outdated
| @@ -143,6 +143,17 @@ async def chat(self, ctx: Context, message: str = None, gpt4: bool = False): | |||
| async def gpt4(self, ctx: Context, message: str): | |||
| await self.chat(ctx, message, True) | |||
|
|
|||
| @commands.hybrid_command() | |||
| async def translate( | |||
| self, ctx: Context, source: str, target: str, message: clean_content | |||
There was a problem hiding this comment.
add a help text to explain what source and target are (see
Line 15 in 4d30f63
Also might be an idea to set a deafult value of source to en or auto
cogs/commands/misc.py
Outdated
| await ctx.send(translated) | ||
|
|
||
| @commands.hybrid_command() | ||
| async def joeltech(self, ctx: Context): |
There was a problem hiding this comment.
tbh im not entirely sure if we need this given :joel_tech: can already be written
There was a problem hiding this comment.
the command should be Joel not Joel tech for this to be effective
There was a problem hiding this comment.
removed it for now, will make something mightier in the future :))
|
use of camelCase in pytho brings me pain but fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.