Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appeal action refactor #292

Merged
merged 22 commits into from
Nov 18, 2020
Merged

Appeal action refactor #292

merged 22 commits into from
Nov 18, 2020

Conversation

supertassu
Copy link
Collaborator

Split appeal actions to a new controller (except replying, those are too different and will be handled separately) and add tests for them.

@supertassu supertassu self-assigned this Sep 12, 2020
@pull-assistant
Copy link

pull-assistant bot commented Sep 12, 2020 •
edited
Loading

Score: 0.93

Best reviewed: commit by commit

Optimal code review plan (1 warning)

     Create new controller for appeal actions, move reserve and release the...

Add tests for reserving and releasing appeals

...eal/AppealActionController.php 88% changes removed in Implement appeal ref...

     Implement appeal referring on the new controller, add tests for them

     Implement developer actions on the new controller, add tests for them

     Implement appeal closing action on the new controller, add test for it

     Use press instead of clickLink for reserving appeals in AppealCommentT...

     Fix message

Powered by Pull Assistant. Last update b813024 ... 72b3d5e. Read the comment docs.

@dqwiki dqwiki added the merge & testing issues When there have been changes merged that cause conflicts with the PR at hand label Nov 18, 2020
dqwiki
dqwiki requested changes Nov 18, 2020
View reviewed changes
Copy link
Member

@dqwiki dqwiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the use of App\MwApi\MwApiUrls throughout many files still will conflict from the merge of #250

@supertassu supertassu removed the merge & testing issues When there have been changes merged that cause conflicts with the PR at hand label Nov 18, 2020
@dqwiki dqwiki merged commit 7917458 into master Nov 18, 2020
@dqwiki dqwiki deleted the appeal-action-refactor branch November 18, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dqwiki dqwiki dqwiki approved these changes

Assignees

@supertassu supertassu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supertassu @dqwiki