Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have FVS return valid execution codes? #36

Open
jgrn307 opened this issue Jan 21, 2024 · 0 comments
Open

Have FVS return valid execution codes? #36

jgrn307 opened this issue Jan 21, 2024 · 0 comments

Comments

@jgrn307
Copy link

jgrn307 commented Jan 21, 2024

I was hoping you would be willing to tweak FVS so if it runs properly, it returns a valid exit code (e.g. 0) or, if it has a problem, it returns some other code.

https://www.agileconnection.com/article/overview-linux-exit-codes

We're wrapping FVS in python and it doesn't behave in quite a "standard" way when facing errors. Thanks!
wagnerds added a commit that referenced this issue Mar 6, 2024
@wagnerds
Squashed commit of the following:
25aca6c 
commit ff7c8a2
Author: lance-david <[email protected]>
Date:   Fri Apr 14 08:51:16 2023 -0600

    Initialization of variables in fmcfir.f
    Label change for AK variant elevation reporting 10's feet to 100's feet

commit 3501d6e
Merge: e6e741b a287651
Author: LANCE R. DAVID <[email protected]>
Date:   Thu Mar 30 07:49:59 2023 -0600

    Merge pull request #37 from forest-service/_pr28_Crookston

    Added testing of the fvs[Get|Set]SpeciesAttrs code.

commit a287651
Author: Nicholas Crookston <[email protected]>
Date:   Mon Mar 13 13:42:29 2023 -0700

    Added testing of the fvs[Get|Set]SpeciesAttrs code.

    Fixed a bug in how stoppoint 7 works. Added more code to the test of the
    APIviaR that would have shown the error had the test been added prior to
    now.  Updated the 'save' files to account for these changes.

    Added test for using fvsCutNow() option in rFVS and added code and
    tests that trap using the thinprsc keyword in a way that causes a conflict
    with the use of the rFVS fvsCutNow function.

commit e6e741b
Author: Daniel Wagner <[email protected]>
Date:   Sun Mar 12 15:51:31 2023 -0400

    clean up of X1 variable from fvsvol.f

commit 3cd3d05
Merge: 524cfb8 2b05de7
Author: LANCE R. DAVID <[email protected]>
Date:   Fri Feb 24 13:30:57 2023 -0700

    Merge pull request #36 from forest-service/Q2-2023-Ver-Numbering

    Updated to version and revision numbers for Q2

commit 2b05de7
Author: Daniel Wagner <[email protected]>
Date:   Fri Feb 24 15:26:42 2023 -0500

    Updated to version and revision numbers for Q2

commit 524cfb8
Merge: 229d13f ffbaba3
Author: LANCE R. DAVID <[email protected]>
Date:   Fri Feb 24 12:07:12 2023 -0700

    Merge pull request #35 from forest-service/new-event-monitor-variables

    New event monitor variables

commit ffbaba3
Merge: 124d8ec 229d13f
Author: Daniel Wagner <[email protected]>
Date:   Fri Feb 24 10:16:21 2023 -0500

    Merge branch 'development' of https://code.fs.usda.gov/forest-service/ForestVegetationSimulator into new-event-monitor-variables

commit 124d8ec
Merge: 5c02911 e373625
Author: Daniel Wagner <[email protected]>
Date:   Fri Feb 17 11:32:05 2023 -0500

    Merge branch 'development' of https://code.fs.usda.gov/forest-service/ForestVegetationSimulator into new-event-monitor-variables

commit 5c02911
Merge: 5668311 652f6a3
Author: Daniel Wagner <[email protected]>
Date:   Thu Feb 16 13:18:37 2023 -0500

    Merge branch 'development' of https://code.fs.usda.gov/forest-service/ForestVegetationSimulator into new-event-monitor-variables

commit 5668311
Author: Daniel Wagner <[email protected]>
Date:   Thu Feb 16 13:18:05 2023 -0500

    Initial event monitor expansion code to include
    before and after stand height weighed by basal area.
    STILL NEEDS TO BE VERIFIED AND TESTED
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgrn307