Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[⬆️] Precommit Hooks #179

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

natmfat
Copy link

@natmfat natmfat commented Jan 16, 2024

  • Installs pre-commit for formatting and (potentially) linting
  • Increases minimum python version to 3.9 from 3.8 (Poetry checks out, this was a necessity to install pre-commit)
  • Adds an extra installation step in the README

Example of workflow:
image

I'm doing this first and then moving onto adding type annotations/linting because the diff created by formatting is pretty large and I don't want to accidentally cause a breaking change that goes under the radar. Additionally, formatting files is a fairly cheap process that won't interfere with commits or waste GitHub action minutes (I'm not sure if this is a paid or free org, but either way precommits are free).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant