Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choose notif time #81

Merged
merged 9 commits into from
Jan 25, 2021
Merged

Choose notif time #81

merged 9 commits into from
Jan 25, 2021

Conversation

saachipahwa
Copy link
Collaborator

Closes #59

@saachipahwa
Copy link
Collaborator Author

Screen.Recording.2021-01-25.at.18.01.27.mov

@saachipahwa
Copy link
Collaborator Author

Untitled.mov

@thevirtuoso1973 thevirtuoso1973 added this to In progress in Implementation via automation Jan 25, 2021
thevirtuoso1973
thevirtuoso1973 requested changes Jan 25, 2021
View reviewed changes
Copy link
Collaborator

@thevirtuoso1973 thevirtuoso1973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check that everything looks fine on small screens.

lib/pages/intro_screen.dart Outdated Show resolved Hide resolved
lib/notification.dart Outdated Show resolved Hide resolved
lib/pages/intro_screen.dart Outdated Show resolved Hide resolved
lib/pages/intro_screen.dart Outdated Show resolved Hide resolved
lib/pages/intro_screen.dart Outdated Show resolved Hide resolved
lib/pages/settings_page.dart Outdated Show resolved Hide resolved
@saachipahwa
Copy link
Collaborator Author

Also check that everything looks fine on small screens.

Made the dots as small as possible and it works on the smallest emulator, hopefully it works for all devices

thevirtuoso1973
thevirtuoso1973 approved these changes Jan 25, 2021
View reviewed changes
Copy link
Collaborator

@thevirtuoso1973 thevirtuoso1973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thevirtuoso1973 thevirtuoso1973 merged commit c7df7e0 into develop Jan 25, 2021
Implementation automation moved this from In progress to Done Jan 25, 2021
@thevirtuoso1973 thevirtuoso1973 deleted the choose-notif-time branch January 25, 2021 23:33
@saachipahwa saachipahwa mentioned this pull request Feb 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thevirtuoso1973 thevirtuoso1973 thevirtuoso1973 approved these changes

Assignees

@saachipahwa saachipahwa

Labels
None yet
Projects
No open projects
Implementation
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saachipahwa @thevirtuoso1973