Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Double / on Running script #293 using bash parameter expansion #297

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

ishuar
Copy link
Contributor

@ishuar ishuar commented Jul 16, 2024

πŸ“š Description

fixes #293

πŸ”– Changes

  • Introduce bash parameter expansion to remove trailing slash from the directories path if explicitly added in the values of the arguments.

βœ… To-do list

  • I updated the CHANGELOG.md to reflect the new feature or fix
  • I updated the documentation to reflect the changes

Additional Notes For Reviewer

  • Passed explicit / in the argument input.
─$ ./bin/bashunit example/                                            
bashunit - 0.14.1
Running example/custom_functions_test.sh
βœ“ Passed: Say hi Alice
βœ“ Passed: Say hi Bob
Running example/script_logic_test.sh
βœ“ Passed: Script 123
βœ“ Passed: Script 456

Tests:      4 passed, 4 total
Assertions: 4 passed, 4 total

 All tests passed 
Time taken: 498 ms

Copy link
Member

@Chemaclass Chemaclass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Chemaclass Chemaclass added the bug Something isn't working label Jul 16, 2024
@Chemaclass
Copy link
Member

@ishuar, can you please add a line on the CHANGELOG.md?

@Chemaclass Chemaclass merged commit 018390e into TypedDevs:main Jul 17, 2024
7 checks passed
@ishuar ishuar deleted the ux/fix-trailing-slash branch July 17, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Double / on Running script
2 participants