Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-4569] optional header authconfig #3886

Merged
merged 7 commits into from
Feb 23, 2022
Merged

[TT-4569] optional header authconfig #3886

merged 7 commits into from
Feb 23, 2022

Conversation

jeffy-mathew
Copy link
Contributor

Add disableHeader flag to authConfig struct
Add validation to check if at least one auth source is enabled

@jeffy-mathew jeffy-mathew self-assigned this Feb 11, 2022
@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Feb 11, 2022

API tests result: success ✅
Branch used: refs/pull/3886/merge
Commit:
Triggered by: pull_request (@jeffy-mathew)
Execution page

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Feb 11, 2022

API tests result: success ✅
Branch used: refs/pull/3886/merge
Commit: 8d0a0af
Triggered by: pull_request (@jeffy-mathew)
Execution page

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Feb 11, 2022

API tests result: success ✅
Branch used: refs/pull/3886/merge
Commit: 2e4f4b3
Triggered by: pull_request (@jeffy-mathew)
Execution page

@jeffy-mathew jeffy-mathew changed the title [TT-4569] Feat/optional header authconfig [TT-4569] optional header authconfig Feb 14, 2022
urbanishimwe
urbanishimwe approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@urbanishimwe urbanishimwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Feb 16, 2022

API tests result: skipped 🚫
Branch used: refs/pull/3886/merge
Commit: ac38d69
Triggered by: pull_request (@jeffy-mathew)
Execution page

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Feb 21, 2022

API tests result: success ✅
Branch used: refs/pull/3886/merge
Commit: 2b099ea
Triggered by: pull_request (@furkansenharputlu)
Execution page

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.0% 92.0% Coverage
0.0% 0.0% Duplication

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Feb 23, 2022

API tests result: success ✅
Branch used: refs/pull/3886/merge
Commit: 3e43df7
Triggered by: pull_request (@jeffy-mathew)
Execution page

@jeffy-mathew jeffy-mathew merged commit fa71b25 into master Feb 23, 2022
@jeffy-mathew jeffy-mathew deleted the feat/optional-header-authconfig branch February 23, 2022 09:48
@jeffy-mathew
Copy link
Contributor Author

/release to release-4

@jeffy-mathew
Copy link
Contributor Author

/release to release-4-lts

@tykbot
Copy link

tykbot bot commented Feb 23, 2022

Working on it! Note that it can take a few minutes.

1 similar comment
@tykbot
Copy link

tykbot bot commented Feb 23, 2022

Working on it! Note that it can take a few minutes.

tykbot bot pushed a commit that referenced this pull request Feb 23, 2022
@jeffy-mathew
[TT-4569] optional header authconfig (#3886)
9195735 
* add disableHeader flag to auth config

* add authconfig validator

* fix typo

* review comment

Co-authored-by: Furkan Senharputlu <[email protected]>
(cherry picked from commit fa71b25)
@tykbot
Copy link

tykbot bot commented Feb 23, 2022

@jeffy-mathew Succesfully merged fa71b257cbe7e15235b895d42fc47a82544c4369 to release-4 branch.

@tykbot
Copy link

tykbot bot commented Feb 23, 2022

Still working...

tykbot bot pushed a commit that referenced this pull request Feb 23, 2022
@jeffy-mathew
[TT-4569] optional header authconfig (#3886)
2053fdf 
* add disableHeader flag to auth config

* add authconfig validator

* fix typo

* review comment

Co-authored-by: Furkan Senharputlu <[email protected]>
(cherry picked from commit fa71b25)
@tykbot
Copy link

tykbot bot commented Feb 23, 2022

@jeffy-mathew Succesfully merged fa71b257cbe7e15235b895d42fc47a82544c4369 to release-4-lts branch.

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Feb 23, 2022 •
edited by jira bot
Loading

API tests result: success ✅
Branch used: refs/heads/master
Commit: fa71b25 TT-4569 optional header authconfig (#3886)

  • add disableHeader flag to auth config

  • add authconfig validator

  • fix typo

  • review comment

Co-authored-by: Furkan Senharputlu [email protected]
Triggered by: push (@jeffy-mathew)
Execution page

This was referenced Nov 29, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkansenharputlu furkansenharputlu furkansenharputlu approved these changes

@urbanishimwe urbanishimwe urbanishimwe approved these changes

@lghiur lghiur Awaiting requested review from lghiur

Assignees

@jeffy-mathew jeffy-mathew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffy-mathew @Tyk-ITS @furkansenharputlu @urbanishimwe