Fix SimpleMetadata removal modification tracking

TurkeyMcMac · Jul 23, 2022 · 5daf5d1 · 5daf5d1
1 parent ccd3104
commit 5daf5d1
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/src/metadata.cpp b/src/metadata.cpp
@@ -116,14 +116,15 @@ const std::string *SimpleMetadata::getStringRaw(const std::string &name, std::st
 
 bool SimpleMetadata::setString(const std::string &name, const std::string &var)
 {
- if (var.empty())
- return m_stringvars.erase(name) > 0;
-
- StringMap::iterator it = m_stringvars.find(name);
- if (it != m_stringvars.end() && it->second == var)
- return false;
-
- m_stringvars[name] = var;
+ if (var.empty()) {
+ if (m_stringvars.erase(name) == 0)
+ return false;
+ } else {
+ StringMap::iterator it = m_stringvars.find(name);
+ if (it != m_stringvars.end() && it->second == var)
+ return false;
+ m_stringvars[name] = var;
+ }
  m_modified = true;
  return true;
 }