Fix test error with Turing >= 0.30 #570
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates the Turing tests for the changes in version 0.30.
I expect that the LKJ tests still fail due to an unfortunate behaviour of LinearAlgebra in Julia 1.10:
On previous Julia versions this example worked:
On the Julia master branch the problem was fixed (maybe in JuliaLang/julia#52464?) but I wonder if we could make the
Vector{Real}
that shows up in DynamicPPL and Bijectors in the first place to avoid this problem also on Julia 1.10. Alternatively, we could useBijectors.pd_upper(X) = collect(UpperTriangular(X)') * collect(UpperTriangular(X))
etc. on Julia 1.10.