Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation for unused dependencies not required by index.js #756

Merged
merged 1 commit into from
May 24, 2017
Merged

Validation for unused dependencies not required by index.js #756

merged 1 commit into from
May 24, 2017

Conversation

DenisCarriere
Copy link
Member

An error will now occur if you have extra dependencies that are not being required in index.js.

Error example

not ok 2 turf-concave @turf/meta is not required in index.js
  ---
    operator: fail
    at: Test.t (/Users/mac/Github/turf-tests/packages/turf/test.js:124:54)
  ...

1..2

@DenisCarriere DenisCarriere added this to the 4.4.0 milestone May 24, 2017
@DenisCarriere DenisCarriere self-assigned this May 24, 2017
@DenisCarriere DenisCarriere merged commit 54f4494 into master May 24, 2017
@DenisCarriere DenisCarriere deleted the turf-tests branch May 24, 2017 18:52
@rowanwins
Copy link
Member

ooo nice little test @DenisCarriere - I'm guilty of that one!

@DenisCarriere
Copy link
Member Author

👍 I'm guilty of this too! That's why I added this

@DenisCarriere DenisCarriere mentioned this pull request Jun 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DenisCarriere DenisCarriere

Labels
testing
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DenisCarriere @rowanwins